From 1728254f3a51b8b4d7de902dd53f12141085109c Mon Sep 17 00:00:00 2001 From: BALATON Zoltan Date: Tue, 12 Jul 2016 23:34:27 +0200 Subject: Remove some unneded variables and conditionals and plug some potential memory leaks --- src/recovery.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) (limited to 'src/recovery.c') diff --git a/src/recovery.c b/src/recovery.c index 134742e..13612c4 100644 --- a/src/recovery.c +++ b/src/recovery.c @@ -168,17 +168,13 @@ int recovery_enter_restore(struct idevicerestore_client_t* client, plist_t build char* value = NULL; irecv_getenv(client->recovery->client, "build-version", &value); info("iBoot build-version=%s\n", (value) ? value : "(unknown)"); - if (value) { - free(value); - value = NULL; - } + free(value); + value = NULL; irecv_getenv(client->recovery->client, "build-style", &value); info("iBoot build-style=%s\n", (value) ? value : "(unknown)"); - if (value) { - free(value); - value = NULL; - } + free(value); + value = NULL; unsigned long radio_error = 0; irecv_getenv(client->recovery->client, "radio-error", &value); @@ -273,6 +269,7 @@ int recovery_send_component(struct idevicerestore_client_t* client, plist_t buil if (!path) { if (build_identity_get_component_path(build_identity, component, &path) < 0) { error("ERROR: Unable to get path for component '%s'\n", component); + free(path); return -1; } } -- cgit v1.1-32-gdbae