libimobiledevice-glue/src/utils.c, branch 1.3.3 A library to collect common code used around the libimobiledevice project utils: Correct ctype(3) usage 2026-10-03T22:28:58+00:00 Masatake Daimon 2025-11-06T16:42:00+00:00 283b6bd7619d7c3f3c98dbeccaeb27e70b9ea38f According to POSIX.1 the argument of ctype(3) functions, including toupper(3), has to either be EOF or a value representable as an unsigned char. If the argument has any other value, the behavior is undefined. This means values of signed char must first be cast to unsigned char, otherwise they will be outside the range of allowed values. glibc attempts to avoid the undefined behavior by defining the functions to work for all integer inputs representable by either an unsigned char or a signed char. NetBSD libc does not, and causes a segfault if the value is invalid. 
According to POSIX.1 the argument of ctype(3) functions, including
toupper(3), has to either be EOF or a value representable as an unsigned
char. If the argument has any other value, the behavior is undefined. This
means values of signed char must first be cast to unsigned char, otherwise
they will be outside the range of allowed values.

glibc attempts to avoid the undefined behavior by defining the functions to
work for all integer inputs representable by either an unsigned char or a
signed char. NetBSD libc does not, and causes a segfault if the value is
invalid.
utils: Remove 'plist helper' from header comment 2025-05-17T17:31:14+00:00 Nikias Bassen 2025-05-17T17:31:14+00:00 db53b67ab75c93a6756c87b30f4506de39e1c964 






Fix compilation on MSVC
2024-11-28T16:32:39+00:00

Duncan Ogilvie

2024-11-26T17:39:28+00:00

9bdf7fe983311e8c573d7c466c2006059645c4ba












Move LIMD_GLUE_API definitions to public headers
2024-01-30T10:30:12+00:00

Nikias Bassen

2024-01-30T10:30:12+00:00

7ddaea319550bd44bb295f935bef038a1ac37c3f












Remove plist-related code in favor of new libplist API
2023-04-19T16:03:31+00:00

Nikias Bassen

2023-04-19T16:03:31+00:00

44f2f758f71a11a419743e415321ba0945a87c0f












[clang-tidy] Do not use else after return/break/continue
2022-04-22T14:57:24+00:00

Rosen Penev

2020-12-24T01:39:01+00:00

c2e237ab5449b42461639c8e1eabbc61d0c386b7

Signed-off-by: Rosen Penev <rosenp@gmail.com>





Signed-off-by: Rosen Penev <rosenp@gmail.com>







[clang-tidy] utils: Fix too small loop variable
2022-04-22T11:18:51+00:00

Rosen Penev

2020-12-24T01:25:59+00:00

1c7619d5d425816a8173c732ae47c1c2e588918b

Found with bugprone-too-small-loop-variable

Signed-off-by: Rosen Penev <rosenp@gmail.com>





Found with bugprone-too-small-loop-variable

Signed-off-by: Rosen Penev <rosenp@gmail.com>







[clang-tidy] use uppercase numeric literals
2022-04-22T11:10:14+00:00

Rosen Penev

2020-12-24T01:19:26+00:00

c6ae88fa11232e198daeab808966301aea557e6c

Found with readability-uppercase-literal-suffix

Signed-off-by: Rosen Penev <rosenp@gmail.com>





Found with readability-uppercase-literal-suffix

Signed-off-by: Rosen Penev <rosenp@gmail.com>







utils: Close file if buffer allocation fails in buffer_read_from_filename()
2022-04-04T04:43:41+00:00

Nikias Bassen

2022-04-04T04:43:41+00:00

0da2aa35f2bdfd5b06fc4564a46298a5d689c4fa

Thanks @demhademha for pointing this out.





Thanks @demhademha for pointing this out.







utils: Use libplist's plist_from_memory instead of duplicating format detection
2022-02-09T02:27:48+00:00

Nikias Bassen

2022-02-09T02:27:48+00:00

ecb0996fd2a3b0539153dd3ef901d137bf498ffe