From 80d5f46cea8f7b8692c0d1f076b52195ba766eef Mon Sep 17 00:00:00 2001 From: orbea Date: Tue, 23 Apr 2024 09:15:51 -0700 Subject: common/userpref: remove X509V3_EXT_cleanup() When building libimobiledevice with libressl 3.9 it fails with an implicit declaration for X509V3_EXT_cleanup(). This was removed in libressl "because it was part of a dangerous, incomplete and mostly useless API". Additionally it doesn't seem to be actually used by libimobiledevice: "It cleans up the stack containing custom extensions which libimobiledevice doesn't use, it's only needed after calls to X509V3_EXT_add{,_list,_alias}()." Reference: https://github.com/libressl/portable/issues/1050 Signed-off-by: orbea --- common/userpref.c | 1 - 1 file changed, 1 deletion(-) diff --git a/common/userpref.c b/common/userpref.c index b64c703..48bcfcb 100644 --- a/common/userpref.c +++ b/common/userpref.c @@ -627,7 +627,6 @@ userpref_error_t pair_record_generate_keys_and_certs(plist_t pair_record, key_da } } - X509V3_EXT_cleanup(); X509_free(dev_cert); EVP_PKEY_free(pubkey); -- cgit v1.1-32-gdbae