From 8778188bc3d4755499563aca618bf51f8f9f2444 Mon Sep 17 00:00:00 2001 From: Nikias Bassen Date: Wed, 2 Nov 2022 13:18:38 +0100 Subject: jplist: Prevent multiplication overflow by casting to larger type Found by CodeQL --- src/jplist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/jplist.c b/src/jplist.c index e615299..d12540e 100644 --- a/src/jplist.c +++ b/src/jplist.c @@ -324,7 +324,7 @@ static int node_estimate_size(node_t *node, uint64_t *size, uint32_t depth, int *size += n_children-1; // number of ':' and ',' if (prettify) { *size += n_children; // number of '\n' and extra space - *size += n_children * (depth+1); // indent for every 2nd child + *size += (uint64_t)n_children * (depth+1); // indent for every 2nd child *size += 1; // additional '\n' } break; @@ -333,7 +333,7 @@ static int node_estimate_size(node_t *node, uint64_t *size, uint32_t depth, int *size += n_children-1; // number of ',' if (prettify) { *size += n_children; // number of '\n' - *size += n_children * ((depth+1)<<1); // indent for every child + *size += (uint64_t)n_children * ((depth+1)<<1); // indent for every child *size += 1; // additional '\n' } break; -- cgit v1.1-32-gdbae