diff options
author | Christophe Fergeau | 2008-12-29 12:37:18 +0100 |
---|---|---|
committer | Matt Colyer | 2009-01-02 09:55:08 -0800 |
commit | b30cd1dc05640ee6468b19e479162946a3722ac1 (patch) | |
tree | dd63e2c128438774adad2542fbfb541a4f836b2c | |
parent | d77ecbe3fbd73418dd72e147a0ac2a89e62b1cd9 (diff) | |
download | libimobiledevice-b30cd1dc05640ee6468b19e479162946a3722ac1.tar.gz libimobiledevice-b30cd1dc05640ee6468b19e479162946a3722ac1.tar.bz2 |
Some variables were unsigned while they should be
dispatch_AFC_packet returns an int, but it was sometimes incorrectly
assigned to a variable of type uint32_t which was then compared for
being less or more than 0.
-rw-r--r-- | src/AFC.c | 10 |
1 files changed, 7 insertions, 3 deletions
@@ -796,7 +796,9 @@ iphone_afc_write_file(iphone_afc_client_t client, iphone_afc_file_t file, { char *acknowledgement = NULL; const int MAXIMUM_WRITE_SIZE = 1 << 15; - uint32 zero = 0, bytes_loc = 0, segments = (length / MAXIMUM_WRITE_SIZE), current_count = 0, i = 0; + uint32 zero = 0, current_count = 0, i = 0; + uint32 segments = (length / MAXIMUM_WRITE_SIZE); + int bytes_loc = 0; char *out_buffer = NULL; if (!client || !client->afc_packet || !client->connection || !file || !bytes) @@ -927,7 +929,8 @@ iphone_error_t iphone_afc_close_file(iphone_afc_client_t client, iphone_afc_file iphone_error_t iphone_afc_seek_file(iphone_afc_client_t client, iphone_afc_file_t file, int seekpos) { char *buffer = (char *) malloc(sizeof(char) * 24); - uint32 seekto = 0, bytes = 0, zero = 0; + uint32 seekto = 0, zero = 0; + int bytes = 0; if (seekpos < 0) seekpos = file->size - abs(seekpos); @@ -980,7 +983,8 @@ iphone_error_t iphone_afc_seek_file(iphone_afc_client_t client, iphone_afc_file_ iphone_error_t iphone_afc_truncate_file(iphone_afc_client_t client, iphone_afc_file_t file, uint32_t newsize) { char *buffer = (char *) malloc(sizeof(char) * 16); - uint32 bytes = 0, zero = 0; + int bytes = 0; + uint32 zero = 0; afc_lock(client); |