Convert int16_t macro error types into enum to improve debugging/type-checking

This simple change provides various benefits for developers like compile
time errors, better auto-completition in editors and the ability of a
debugger to show the constant instead of just the raw value.
Thanks to Aaron Burghardt for the proposal.

1 files changed, 13 insertions, 16 deletions

diff --git a/include/libimobiledevice/restore.h b/include/libimobiledevice/restore.h
index 63f8915..9373249 100644
--- a/include/libimobiledevice/restore.h
+++ b/include/libimobiledevice/restore.h
@@ -30,22 +30,19 @@ extern "C" {
 
 #include <libimobiledevice/libimobiledevice.h>
 
-/** @name Error Codes */
-/*@{*/
-#define RESTORE_E_SUCCESS                     0
-#define RESTORE_E_INVALID_ARG                -1
-#define RESTORE_E_INVALID_CONF               -2
-#define RESTORE_E_PLIST_ERROR                -3
-#define RESTORE_E_DICT_ERROR                 -4
-#define RESTORE_E_NOT_ENOUGH_DATA            -5
-#define RESTORE_E_MUX_ERROR                  -6
-#define RESTORE_E_START_RESTORE_FAILED       -7
-
-#define RESTORE_E_UNKNOWN_ERROR            -256
-/*@}*/
-
-/** Represents an error code. */
-typedef int16_t restored_error_t;
+/** Error Codes */
+typedef enum {
+	RESTORE_E_SUCCESS              =  0,
+	RESTORE_E_INVALID_ARG          = -1,
+	RESTORE_E_INVALID_CONF         = -2,
+	RESTORE_E_PLIST_ERROR          = -3,
+	RESTORE_E_DICT_ERROR           = -4,
+	RESTORE_E_NOT_ENOUGH_DATA      = -5,
+	RESTORE_E_MUX_ERROR            = -6,
+	RESTORE_E_START_RESTORE_FAILED = -7,
+	RESTORE_E_DEVICE_ERROR         = -8,
+	RESTORE_E_UNKNOWN_ERROR        = -256
+} restored_error_t;
 
 typedef struct restored_client_private restored_client_private;
 typedef restored_client_private *restored_client_t; /**< The client handle. */