summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2022-02-07jplist: Prevent integer overflow when parsing numerical valuesGravatar Nikias Bassen1-6/+29
Credit to OSS-Fuzz
2022-02-05configure: Generate usable version via git-version-gen when ran in shallow cloneGravatar Nikias Bassen1-1/+5
2022-02-03jplist: Fix OOB read by making sure number of children is evenGravatar Nikias Bassen2-2/+7
Credit to OSS-Fuzz
2022-02-02configure: Prevent wrong version string generation (e.g. when doing a ↵Gravatar Nikias Bassen1-1/+1
shallow checkout from git)
2022-02-02jplist: Fix memory leak on parse errorGravatar Nikias Bassen2-0/+3
Credit to OSS-Fuzz
2022-02-02jplist: Improve numerical value parsing without copying data to stack bufferGravatar Nikias Bassen1-18/+62
Instead of calling strtoll() and atof(), the code now parses the numerical values directly to handle cases of non-0-terminated string data. The floating point value parsing is probably not ideal, but sufficient for our purposes.
2022-01-31jplist: Fix memory leak that occurs when JSON parsing failsGravatar Nikias Bassen2-0/+2
Credit to OSS-Fuzz
2022-01-31plistutil: Make sure the input buffer is 0-terminated in all code pathsGravatar Nikias Bassen1-0/+1
2022-01-31test: Update JSON test case to have negative numbersGravatar Nikias Bassen1-1/+1
2022-01-31jplist: Fix OOB read in parse_primitive caused by missing 0-terminationGravatar Nikias Bassen1-2/+8
In parse_primitive, integer and double values are parsed by using strtoll and atof, which both expect the string to be 0-terminated. While this is not a problem in well-formed JSON files, it can be if the JSON data is not, possibly leading to a crash due to OOB memory access. This commit fixes it by copying the value data in question to a stack buffer and 0-terminate it, and use that buffer instead. Credit to OSS-Fuzz
2022-01-31fuzz: Add another JSON test case from OSS-FuzzGravatar Nikias Bassen1-0/+1
2022-01-31jplist: Fix OOB read by making sure the JSMN token index is in valid rangeGravatar Nikias Bassen1-31/+48
Credit to OSS-Fuzz
2022-01-28fuzz: Add JSON crash/leak test cases from OSS-FuzzGravatar Nikias Bassen3-0/+3
2022-01-28jplist: Fix a few memory leaks that occur when parsing failsGravatar Nikias Bassen1-0/+5
Credit to OSS-Fuzz
2022-01-28jplist: Fix NULL pointer dereference by handling errors from unescape_string ↵Gravatar Nikias Bassen1-0/+6
correctly Credit to OSS-Fuzz
2022-01-28jplist: Fix use-after-free in unescape_stringGravatar Nikias Bassen1-2/+2
Credit to OSS-Fuzz
2022-01-26[github-actions] Also checkout all tags for codeqlGravatar Nikias Bassen1-1/+1
2022-01-26[github-actions] Make sure to fetch all tags on checkoutGravatar Nikias Bassen1-0/+6
2022-01-25jplist: Make sure the jsmn parser tokens are initialized properlyGravatar Nikias Bassen1-3/+6
2022-01-25test: Rename json test files to .jsonGravatar Nikias Bassen5-3/+4
2022-01-25configure: Fix clang detection when configuring --with-fuzzersGravatar Nikias Bassen1-2/+7
2022-01-25fuzz: Add fuzzer for JSON formatGravatar Nikias Bassen6-4/+110
2022-01-25autoconf: Automatically derive version number from latest git tagGravatar Nikias Bassen3-2/+26
2022-01-25test: Add additional JSON test caseGravatar Nikias Bassen4-7/+28
2022-01-25jplist: Make sure key values are also unescapedGravatar Nikias Bassen1-12/+19
2021-12-24json: Update parser (jsmn) to verify the length of the input dataGravatar Nikias Bassen3-7/+17
This way the string doesn't have to be 0-terminated.
2021-12-23test: Work around JSON parser limitation expecting to have a 0-terminated ↵Gravatar Nikias Bassen1-0/+3
string as input
2021-12-23test: Update json test case to not rely on --enable-debugGravatar Nikias Bassen1-9/+6
2021-12-23plistutil: Check return values from plist API to print proper error messagesGravatar Nikias Bassen1-14/+35
and return a meaningful exit code.
2021-12-23jplist: Make strndup argument const to silence compiler warningGravatar Nikias Bassen1-1/+1
2021-12-23[github-actions] Fix test suite failing due to missing debug outputGravatar Nikias Bassen1-3/+3
2021-12-23jplist: Fix build on WindowsGravatar Nikias Bassen1-0/+12
2021-12-23Add support for JSON formatGravatar Nikias Bassen20-66/+1403
2021-12-23test: Add PLIST_UID test caseGravatar Nikias Bassen4-3/+155
2021-12-23xplist: Add special handling for PLIST_UID parsing from XMLGravatar Nikias Bassen1-5/+14
In XML, PLIST_UID nodes are stored as a dict with a "CF$UID" key and an integer value, so we want to make it a real PLIST_UID node internally.
2021-12-22Add a return value to plist_to_* and plist_from_* functionsGravatar Nikias Bassen4-43/+120
This way it can be easier determined why an import/export operation failed instead of just having a NULL result.
2021-12-19Add support for PLIST_NULL typeGravatar Nikias Bassen4-15/+60
2021-12-19Fix 'make docs' target deleting the whole docs subdirGravatar Nikias Bassen1-1/+1
2021-12-19Add new plist_mem_free() functionGravatar Nikias Bassen4-24/+28
Thanks to @azerg for bringing this to my attention. Instead of having multiple (internally identical) plist_*_free() functions, this commit introduces a single plist_mem_free() that can be used to free the memory allocated by plist_to_xml(), plist_to_bin(), plist_get_key_val(), plist_get_string_val(), and plist_get_data_val(). Note: This commit REMOVES plist_to_bin_free() and plist_to_xml_free().
2021-11-08xplist: Better size estimation for PLIST_REAL nodesGravatar Nikias Bassen1-2/+2
2021-09-21[github-actions] Add an explicit apt-get update before attempting to install ↵Gravatar Nikias Bassen1-0/+1
packages on ubuntu
2021-09-17[github-actions] Remove git checkout HEAD^2 step for CodeQLGravatar Nikias Bassen1-5/+0
2021-09-13Check availability of constructor attribute and use it on Windows in favor ↵Gravatar Nikias Bassen2-20/+45
of DllMain
2021-09-11windows: Make thread_once static and remove const qualifiers from ↵Gravatar Nikias Bassen1-3/+3
thread_once_t globals
2021-09-11Update deprecated autoconf macros and update m4 filesGravatar Nikias Bassen4-127/+172
2021-07-13cpp: Array: Make sure the array passed to array_fill ist passed by referenceGravatar liujianfengv1-1/+1
When creating a new Array object, for example through PList::Node::FromPlist(plist_t node), the array_fill function is called from Array() constructor in line 51. It seems that the intended way of calling array_fill() is to pass the _array object by reference, however it is actually passed by value. Thus the changes to the array object made by array_fill() are discarded when the function returns. This commit passes the _array by reference so we keep the changes.
2021-06-30README: Fix typoGravatar Nikias Bassen1-1/+1
2021-06-22[clang-tidy] Remove casts to the same typeGravatar Rosen Penev2-2/+2
Found with google-readability-casting Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-06-22[clang-tidy] cpp: Replace free with deleteGravatar Rosen Penev5-19/+9
It's the C++ way. It also avoids having to check for NULL. Found with cppcoreguidelines-owning-memory Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-06-22[clang-tidy] Fix bad widening castsGravatar Rosen Penev1-2/+2
Found with bugprone-misplaced-widening-cast Signed-off-by: Rosen Penev <rosenp@gmail.com>
© 2009-2020 libimobiledevice.org - All rights reserved - Generated by cgit - Icons from Tango - Uses Google Analytics